fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 )

Change subject: gbproxy: Add "show gbproxy cell ..." VTY command
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c
File src/gbproxy/gb_proxy_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c@251
PS7, Line 251: DEFUN(show_gbproxy_cell, show_gbproxy_cell_cmd, "show gbproxy 
cell [stats]",
This looks wrong to me: you have 4 words in the command vector, and 5 
docstrings?



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5
Gerrit-Change-Number: 21692
Gerrit-PatchSet: 7
Gerrit-Owner: laforge <[email protected]>
Gerrit-Assignee: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Thu, 17 Dec 2020 23:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to