Re: 2 Hardware acceleration quiestions

[Marcus Sundberg]

[EMAIL PROTECTED] wrote:
> 
> Hi !
> 
> > ioctl(3, 0x400c0514, 0xbffffc3c)        = 0
> > ioctl(3, 0x400c0530, 0xbffffc3c)        = -83886082

Seems there was a bug in the kgicon layer, simply passing the
return value from the driver on to userspace. The following
diff fixes that:

--- fbcon-kgi.c 1999/09/23 19:39:17     1.69
+++ fbcon-kgi.c 1999/09/30 23:58:44
@@ -1545,11 +1545,11 @@
                default:
                        type -= KGI_IOCTLBASE;
                        res = ((type < KGI_NR_SUBSYSTEMS)
-                              && (kgifb_display.cmd[type]))
-                               ? kgifb_display.cmd[type](&kgifb_graph,
-                                                         cmd, arg)
-                               : -EINVAL;
-                       if ((cmd & IOC_OUT) && (res == EOK)) {
+                              && (kgifb_display.cmd[type])
+                              && kgifb_display.cmd[type](&kgifb_graph,
+                                                         cmd, arg) ==
0)
+                               ? 0 : -EINVAL;
+                       if ((cmd & IOC_OUT) && (res == 0)) {
                                if (kgifb_graph.io_res
                                    && (0 < kgifb_graph.io_cnt)
                                    && (kgifb_graph.io_cnt

> Weird. Seems the manpage is not correct here.

Sure it is. The manpage documents the library API, while strace shows
syscalls.

//Marcus
-- 
-------------------------------+------------------------------------
        Marcus Sundberg        | http://www.stacken.kth.se/~mackan/
 Royal Institute of Technology |       Phone: +46 707 295404
       Stockholm, Sweden       |   E-Mail: [EMAIL PROTECTED]