the responses have been very positive so far, so I've given this a
little more testing. There are a couple of dialogs where the help
button is not appropriate and just looks odd. These are mainly
confirmation dialogs like for example the one you get when you close
an image.  I suggest that we don't set a help-id on such dialogs. We
can set the help_func so that pressing F1 opens the help-browser with
the default page but there would not be a help button. In particular
this means removing the following help-ids:

#define GIMP_HELP_FILE_NEW_CONFIRM       "gimp-file-new-confirm"
#define GIMP_HELP_FILE_SAVE_OVERWRITE    "gimp-file-save-overwrite"
#define GIMP_HELP_FILE_CLOSE_CONFIRM     "gimp-file-close-confirm"
#define GIMP_HELP_FILE_QUIT_CONFIRM      "gimp-file-quit-confirm"
#define GIMP_HELP_EXPORT_CONFIRM_DIALOG  "gimp-export-confirm-dialog"

Would that make sense?

There are a couple of other dialogs where the help button disturbs the
dialog layout and I am sure there are some dialogs that I didn't look
at yet. So if you agree with the above change I will investigate what
needs to be done to make the help button configurable. If it turns out
that this is feasible, I would commit this change so that it can see
some more testing with the 2.1.6 release.

Gimp-developer mailing list

Reply via email to