Hi,

On Fri, 2008-03-14 at 13:59 +0100, Marcus Heese wrote:
> Hello together,
> 
> so for now I've finished my work on the new implementation of the text layer 
> in the PDB api.
> 
> The most actualized version can always be downloaded from here:
> http://www.cip.ifi.lmu.de/~heese/text_layer.pdb

Oh, and it would be nice if you could remove the commented out function
gimp_layer_is_text_layer(). And please inline the gimp_text variable
where possible:

      gimp_text = gimp_text_layer_get_text (GIMP_TEXT_LAYER (layer));
      g_object_get (gimp_text,
                    "text", &text,
                    NULL);

should become:

      g_object_get (gimp_text_layer_get_text (GIMP_TEXT_LAYER (layer),
                    "text", &text,
                    NULL);

We can probably factor out some common code like the check if the passed
drawable is a text layer. But that can as well be done in a second step.


Sven


_______________________________________________
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Reply via email to