[ 
https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143314#comment-13143314
 ] 

Avery Ching commented on GIRAPH-64:
-----------------------------------

Jakob, pulled the diff from your last rb (updating is better than using a new 
reviewboard to see changes fyi).  I got the following issues on 'mvn package'

 mvn package
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Incubator Giraph 0.70
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-maven) @ giraph ---
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ giraph 
---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/Users/aching/Documents/workspace/Trunk Apache Giraph/src/main/resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ giraph ---
[INFO] Compiling 87 source files to /Users/aching/Documents/workspace/Trunk 
Apache Giraph/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[136,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[138,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[139,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[140,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[141,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[142,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[143,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[144,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[145,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[146,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[147,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[148,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[149,0] class, 
interface, or enum expected
[ERROR] /Users/aching/Documents/workspace/Trunk Apache 
Giraph/src/main/java/org/apache/giraph/GiraphRunner.java:[150,0] class, 
interface, or enum expected
[INFO] 14 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

                
> Create VertexRunner to make it easier to run users' computations
> ----------------------------------------------------------------
>
>                 Key: GIRAPH-64
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-64
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-64.patch
>
>
> Currently, if a user wants to implement a Giraph algorithm by extending 
> {{Vertex}} they must also write all the boilerplate around the {{Tool}} 
> interface and bundle it with the Giraph jar (or get Giraph on the classpath 
> and playing nice with the implementation).  For example, what is included in 
> the PageRankBenchmark and what Kohei has done: 
> https://github.com/smly/java-Giraph-LabelPropagation  It would be better if 
> we had perhaps a Vertex implementation to be subclassed that already had all 
> the standard Tooling included such that all one had to run would be (assuming 
> the Giraph jar was already on the classpath):
> {noformat}hadoop jar my-awesome-vertex.jar my.awesome.vertex -i jazz_input -o 
> jazz_output -if org.apache.giraph.lib.in.text.adjacency-list.LongDoubleDouble 
> -of org.apache.giraph.lib.out.text.adjacency-list.LongDoubleDouble{noformat} 
> This wouldn't work with every algorithm, but would be useful in a large 
> number of cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to