Claudio Martella commented on GIRAPH-74:

I agree with you to this extent, I synched it to the others willing to drop 
get/set methods.

I could refactor to the return value of compute, but I'm afraid it would break 
the things here and there. We would still have to keep the state of the vertex 

My favorite would be to have package-level set/get.
> GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
> ---------------------------------------------------------------------------
>                 Key: GIRAPH-74
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-74
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>             Fix For: 0.70.0
>         Attachments: GIRAPH-36-cleaup.diff, GIRAPH-70.diff
> After GIRAPH-36, in a couple of places Vertex was left instead of 
> BasicVertex. To achieve the fix a BasicVertex was extended with a new boolean 
> isHalted(boolean state) method that totally hides boolean halt field. I 
> believe this unifies the voteToHalt() and isHalted() methods totally hiding 
> the halting management of Vertices (before it was relying on the existence of 
> boolean halt field).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to