Avery Ching commented on GIRAPH-100:

Sorry Jakob, I'll try to stop doing formatting changes.  Habit, I suppose.  In 
the future, I'll file separate issues for formatting cleanup.

    What's the point of the changes in TextVertexInputFormat method visibility? 
Are they related to this patch?

No, I can remove it.  Just a bit safer I guess since they should be protected.

    We're throwing a lot of Stringly typed exceptions. For more robust error 
handling and recovery, it may be good to strongly type these instead.

Which exceptions are you referring to?

    re: SuperstepHashPartitionerFactory. Moving it out of test and into the 
example directory seems a bit counterproductive to me. It's a pathological 
implementation; wouldn't it be better to provide a more useful example, rather 
than one that's explicitly not meant to be used?

Until we start jaring up things separately, currently the Hadoop unit test is 
broken when the SuperstepHashPartitionerFactory is not found.  The right 
solution might be to create another jar that has the unittest classes and can 
be run as part of the Hadoop instance unittest.  Can we do that in another 
issue?  I agree that it isn't a good example, but it's still a good test since 
it guarantees partition movement between workers.

> Data input sampling and testing improvements
> --------------------------------------------
>                 Key: GIRAPH-100
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-100
>             Project: Giraph
>          Issue Type: New Feature
>          Components: graph
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-100.patch
> It would be really nice to help debug an application by limiting the input 
> data (% of input splits, max vertices per input split).  Also, it would be 
> nice for the workers to provide a little more debugging info on how far along 
> they are with processing the input data.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to