Avery Ching commented on GIRAPH-10:

Much improved Claudio.

A couple more minor suggestions:

Please add a javadoc comment for the class SimpleAggregatorWriter on what it 
does (given that it is in examples and users will be looking for help on what 
it is doing).


Before line 356: assertTrue(job.run(true));

Should add something like (as in other tests in that file):

Path outputPath = new Path("/tmp/" + getCallingMethodName());
removeAndSetOutput(job, outputPath);

If you don't do this, the next time someone adds another test to this dir and 
it doesn't set the output dir, it could potentially cause issues I think if 
they are relying on specific stuff in that dir.

By the way, good bug fix in the test.

If you agree and make those changes, this is an effective +1, please upload 
your final diff and feel free to commit. =)

> Aggregators are not exported
> ----------------------------
>                 Key: GIRAPH-10
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-10
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Avery Ching
>            Assignee: Claudio Martella
>            Priority: Minor
>         Attachments: GIRAPH-10.diff, GIRAPH-10.diff, GIRAPH-10.diff
> Currently, aggregator values cannot be saved after a Giraph job.  There 
> should be a way to do this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to