[ 
https://issues.apache.org/jira/browse/GIRAPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Schelter updated GIRAPH-105:
--------------------------------------

    Attachment: GIRAPH-105-2.patch

updated patch to reflect aching's suggestions, ran local and pseudo distributed 
unit-tests
                
> BspServiceMaster.checkWorkers() should return empty lists instead of null
> -------------------------------------------------------------------------
>
>                 Key: GIRAPH-105
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-105
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.70.0
>            Reporter: Sebastian Schelter
>            Priority: Minor
>         Attachments: GIRAPH-105-2.patch, GIRAPH-105.patch
>
>
> BspServiceMaster.checkWorkers() is invoked in 
> BspServiceMaster.coordinateSuperstep() and in 
> BspServiceMaster.createInputSplits(). Both check for an empty list to fail 
> the job in case something has gone wrong. However, checkWorkers() returns 
> null in case of problems, causing an NPE in the calling code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to