[ 
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208750#comment-13208750
 ] 

Jakob Homan commented on GIRAPH-40:
-----------------------------------

Actually, I have a concern:
> Compiles will now fail if checkstyle guidelines are not met.
I tested this and it's true.  This means that if you have an extra space in an 
if statement, you can't compile, even if you're planning to clean up the code 
later.  This is going to be a huge problem.  During development the code has to 
*always* pass checkstyle, not just when submitting a patch.  Is there a way to 
turn this off for compile and just run checkstyle during a specific run? This 
would mean that it would be up to the submitted and committer to verify 
correctness, exactly as is required currently with rat... I have to withdraw my 
-1.
                
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
>                 Key: GIRAPH-40
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-40
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>            Priority: Minor
>         Attachments: GIRAPH-40.2.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce 
> them with a maven checkstyle plugin.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to