[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209814#comment-13209814
]
Hudson commented on GIRAPH-40:
------------------------------
Integrated in Giraph-trunk-Commit #83 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/83/])
GIRAPH-40: Added checkstyle for enforcement of code conventions. All
Giraph source files now pass checkstyle. (aching). (Revision 1245205)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245205
Files :
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/checkstyle.xml
* /incubator/giraph/trunk/license-header.txt
* /incubator/giraph/trunk/pom.xml
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/HashMapVertexPageRankBenchmark.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankComputation.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/ApplicationState.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspInputSplit.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspOutputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspRecordReader.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspRecordWriter.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/ImmutableOutputCommitter.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/SuperstepState.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/ArrayListWritable.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/MsgList.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/RPCCommunications.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/ServerInterface.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/VertexIdMessages.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/VertexIdMessagesList.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/VertexList.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/WorkerCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/ConnectedComponentsVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/GeneratedVertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/IntIntNullIntTextInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/LongSumAggregator.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/MaxAggregator.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/MinAggregator.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleAggregatorWriter.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCombinerVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleFailVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMsgVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleTextVertexOutputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SumAggregator.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/VerifyMessage.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/VertexWithComponentTextOutputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Aggregator.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/AggregatorUsage.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/AggregatorWriter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Edge.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GlobalStats.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphState.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/HashMapVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/IntIntNullIntVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MasterThread.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MutableVertex.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexChanges.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexCombiner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexEdgeCount.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexMutations.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexOutputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexReader.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexResolver.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexWriter.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerInfo.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/BasicPartitionOwner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/GraphPartitionerFactory.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashMasterPartitioner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashPartitionerFactory.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashRangePartitionerFactory.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashRangeWorkerPartitioner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/MasterGraphPartitioner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/Partition.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionBalancer.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionExchange.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionOwner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionStats.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionUtils.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangeMasterPartitioner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangePartitionOwner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangePartitionStats.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangeSplitHint.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangeWorkerPartitioner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/WorkerGraphPartitioner.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/hadoop/BspPolicyProvider.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/hadoop/BspTokenSelector.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/hadoop/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/integration/SuperstepHashPartitionerFactory.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/integration/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/AdjacencyListTextVertexOutputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/AdjacencyListVertexReader.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/IdWithValueTextOutputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexOutputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/LongDoubleDoubleAdjacencyListVertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/SequenceFileVertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/TextDoubleDoubleAdjacencyListVertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/TextVertexInputFormat.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/TextVertexOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/package-info.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/ComparisonUtils.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/EmptyIterable.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/MemoryUtils.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/ReflectionUtils.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/UnmodifiableIntArrayIterator.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/WritableUtils.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/BspEvent.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ContextLock.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/PredicateLock.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperExt.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/package-info.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
*
/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java
*
/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
*
/incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleShortestPathVertexTest.java
*
/incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/utils/MockUtils.java
* /incubator/giraph/trunk/src/test/java/zk/TestZooKeeperManager.java
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch,
> GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce
> them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
