[ 
https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eli Reisman updated GIRAPH-87:
------------------------------

    Attachment: GIRAPH-87.patch

This is an improved version of GIRAPH-87.patch that passes "mvn 
checkstyle:check" and of course also "mvn test". Not tested on a cluster.
                
> Simplify boolean expression in BspService::checkpointFrequencyMet
> -----------------------------------------------------------------
>
>                 Key: GIRAPH-87
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-87
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>              Labels: newbie
>         Attachments: GIRAPH-87.patch, GIRAPH-87.patch
>
>
> {noformat}        if (superstep < firstCheckpoint) {
>             return false;
>         } else if (((superstep - firstCheckpoint) % checkpointFrequency) == 
> 0) {
>             return true;
>         } else {
>             return false;
>         }{noformat}
> can be simplified to just return the result of the else if evaluation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to