[
https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221208#comment-13221208
]
Eli Reisman commented on GIRAPH-87:
-----------------------------------
Thanks again, looking forward to doing more comprehensive fixes in the
future!
On Sat, Feb 25, 2012 at 12:19 AM, Avery Ching (Commented) (JIRA) <
> Simplify boolean expression in BspService::checkpointFrequencyMet
> -----------------------------------------------------------------
>
> Key: GIRAPH-87
> URL: https://issues.apache.org/jira/browse/GIRAPH-87
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Jakob Homan
> Assignee: Eli Reisman
> Labels: newbie
> Attachments: GIRAPH-87.patch, GIRAPH-87.patch
>
>
> {noformat} if (superstep < firstCheckpoint) {
> return false;
> } else if (((superstep - firstCheckpoint) % checkpointFrequency) ==
> 0) {
> return true;
> } else {
> return false;
> }{noformat}
> can be simplified to just return the result of the else if evaluation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
