Eli Reisman updated GIRAPH-85:

    Attachment: GIRAPH-85-3.patch

This adds the SupressWarnings("unchecked") annotation to several methods that 
seem to need it for mvn verify to run successfully. It also simplifies one more 
spot in RPCCommunications.java where variables are used to temporarily hold a 
return value, but nothing is done with that value before returning it. This 
brings the grand total to 3 places where this change was made.

I would like to throw the idea out there that assigning to the "proxy" and 
other variables for a moment DOES have a clarity benefit that I would hate to 
prune out of the codebase just to help me practice uploading patches, which I 
have done on GIRAPH-87 and GIRAPH-157. If someone else wants to take a crack at 
this or if you guys just want to leave it the way already is to forego this 
extra practice, I will not be upset!

If not, I think this patch will work.

> Simplify return expression in RPCCommunications::getRPCProxy
> ------------------------------------------------------------
>                 Key: GIRAPH-85
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-85
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>              Labels: newbie
>             Fix For: 0.2.0
>         Attachments: GIRAPH-85-3.patch, GIRAPH-85.patch, GIRAPH-85.patch
> Twice in RPCCommunications::getRPCProxy a local variable, proxy, is created 
> and immediately returned.  We can simplify this to just return the value.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to