Commit:     bad60fdd14df32459e31cc75ab681e4458bf25cf
Parent:     041388b54ed95cd169546bd83bacd08ee32bd7ea
Author:     Christoph Hellwig <[EMAIL PROTECTED]>
AuthorDate: Fri Dec 21 10:58:56 2007 +1100
Committer:  Lachlan McIlroy <[EMAIL PROTECTED]>
CommitDate: Fri Dec 21 11:39:58 2007 +1100

    [XFS] Fix mknod regression
    This was broken by my '[XFS] simplify xfs_create/mknod/symlink prototype',
    which assigned the re-shuffled ondisk dev_t back to the rdev variable in
    xfs_vn_mknod. Because of that i_rdev is set to the ondisk dev_t instead of
    the linux dev_t later down the function.
    Fortunately the fix for it is trivial: we can just remove the assignment
    because xfs_revalidate_inode has done the proper job before unlocking the
    SGI-PV: 974873
    SGI-Modid: xfs-linux-melb:xfs-kern:30273a
    Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
    Signed-off-by: David Chinner <[EMAIL PROTECTED]>
    Signed-off-by: Lachlan McIlroy <[EMAIL PROTECTED]>
 fs/xfs/linux-2.6/xfs_iops.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index 37e1167..5e8bb7f 100644
--- a/fs/xfs/linux-2.6/xfs_iops.c
+++ b/fs/xfs/linux-2.6/xfs_iops.c
@@ -332,9 +332,7 @@ xfs_vn_mknod(
                ip = vn_to_inode(vp);
-               if (S_ISCHR(mode) || S_ISBLK(mode))
-                       ip->i_rdev = rdev;
-               else if (S_ISDIR(mode))
+               if (S_ISDIR(mode))
                d_instantiate(dentry, ip);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to