Junio C Hamano <[EMAIL PROTECTED]> wrote: > "Shawn O. Pearce" <[EMAIL PROTECTED]> writes: > > > git-gui was incorrectly parsing "--- foo" as the old file name > > in the file header, causing it to generate a bad patch file when > > the user tried to stage or unstage a hunk or the selected line. > > We need to keep track of where we are in the parsing so that we do > > not misread a deletion or addition record as part of the header. > > While keeping track of state is obviously a good change, it also might be > worth noticing "@@ -k,l +m,n @@" header and actively using the > information.
Yea. But that was a lot more work. Noticing a hunk header, getting the line counts from it, then keeping a running counter to know how many lines before either EOF or the next header are all part of that hunk is just a lot of code I didn't feel like writing this evening. ;-) -- Shawn. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Git for human beings" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/git-users?hl=en -~----------~----~----~----~------~----~------~--~---
