>>>>> "PB" == Petr Baudis <[EMAIL PROTECTED]> writes:

PB> P.S.: It seems that Linus applied a patch to ls-tree which will make it
PB> read_sha1_file() on each item when ls-tree is recursive. Junio, why did
PB> you do it?

Sorry it was my misunderstanding, before I found out exactly how
S_ISDIR is used.  Thank you for pointing it out.

I was confused by this comment around the area I changed:

    /* XXX: We do some ugly mode heuristics here.
     * It seems not worth it to read each file just to get this
     * and the file size. -- [EMAIL PROTECTED]

I mistakenly inferred from that comment that S_ISDIR(mode) is
not a guarantee.  So I mistakenly optimized it for non-recursive
case by keeping that "heuristics".  The logic was: If recursive
we will need to run read_sha1_file() to find out if it is really
a tree anyway.

I'll fix it up, now I know S_ISDIR(mode) is a guarantee that it
is a tree, I'll do the "heuristics" first, and do read_sha1_file
only when it is a tree and I am recursive.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to