Dear diary, on Tue, Apr 19, 2005 at 12:18:07AM CEST, I got a letter where David Greaves <[EMAIL PROTECTED]> told me that... > Petr Baudis wrote: > > > Thanks. Could you please send the patches signed off and either with > > content-disposition: inline or in the mail body? > Is this OK. > Thunderbird isn't the best for attaching patches.
Yes. The patch you inserted is useless, whitespaces are mangled away. > > I think it would be cleaner to do the testing for the dash in the for > > loop, so that I can do git add foo bar -. Also, don't forget to > > update git add's documentation at the top. For the usage string, I'd > > probably prefer (-|FILE)... > > > > thanks, > > Here you are: > * git add and git rm now take (-|FILE)... > * noted some bugs to be fixed > * introduced de-dupe code into add and rm > * git status reports added/removed files (although there are extra entries) > * README, git and command docs updated > > I realise as I write this that I should have split these patches up - I > will do so next time. Well, I didn't ask you to split the patch the first time since it was quite trivial for me to do, but this is too much. ;-) > Has a decision been reached to _not_ code the cogito part of the git > suite in perl? > > I ask because the code in git status is getting pretty ugly. > I'd be happy to help with a preliminary port to perl. I'm fine with Perl. I chose shell for the very initial implementation since it actually was simplest, but now, I wouldn't have anything against Perl if it makes is simpler. (And as long as your Perl is nice. I'm harsh reviewer. ;-) > Index: gitadd.sh > =================================================================== > --- c0aff9b98c4242ab8965c428241df1d8f7a1d4bb/gitadd.sh (mode:100755 > sha1:3ed93ea0fcb995673ba9ee1982e0e7abdbe35982) > +++ cd5cd7a9272ce1966aca3bfce15f703e33cafc04/gitadd.sh (mode:100755 > sha1:a3e83ac52abd5a9cdc6abd560f95b2f19646fd99) > \ No newline at end of file Note this. Something is wrong with your text editor, too. Kind regards, -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html