On Sat, Jul 23, 2005 at 02:11:16AM -0700, Junio C Hamano wrote:
> Ryan Anderson <[EMAIL PROTECTED]> writes:
>
> > --- a/debian/changelog
> > +++ b/debian/changelog
> > ...
> > + * Minor tweaks to the Build-Depends.
>
> This is a nit and not the reason for NACK, but I do not see any
> change to Build-Depends.
>
> > -Depends: ${misc:Depends}, shellutils, diff, rsync, rcs
> > +Depends: ${misc:Depends}, patch, diff, rsync, rcs, wget, rsh-client
Just to be clear - I was forwarding Sebastian's patch on, after fixing
up the conflict I got applying it, so I didn't edit the comments, other
than to add my Signed-off-by line.
> This is primarily my fault, but this new Depends line is already
> obsolete. Darrin Thompson removed the last remaining use of
> wget and it is my understanding that we do not depend on wget
> anymore; instead we now depend on curl executable.
>
> I do not offhand remember where we use rsh-client. The
> rsh-client I know of is this one, which claims to offer rsh, rcp
> and rlogin but I do not think we use any of them. Did you mean
> "ssh" package?
ssh Provides rsh-client.
I suspect that was the thinking. I think the way we use ssh should be
compatible with rsh, and that was the underlying reason for doing it
this way.
> Both the use of mozilla SHA1 library and conflicting with the
> other GIT, which are the primary points of this patch, sound
> sensible, relative to the Debian poli(cies|tics), but as long as
> we are touching the Depends: line, let's make sure we get it
> right (the current one is obviously obsolete).
I have no issue with the hunk being dropped or just doing a followup to
fix things up. I'll wait until Linus settles back in and our massive
backlog is fully committed or commented on.
--
Ryan Anderson
sometimes Pug Majere
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
