Jeff King <p...@peff.net> writes:

> @@ -216,7 +190,9 @@ sub credential_write {
>  sub credential_run {
>       my $op = shift;
>       my $credential = shift;
> +     my $url = shift;
>       my $pid = open2(my $reader, my $writer, "git credential $op");
> +     print $writer "url=$url\n" if defined $url;
>       credential_write($credential, $writer);
>       print $writer "\n";
>       close($writer);
> @@ -246,10 +222,10 @@ sub mw_connect_maybe {
>       $mediawiki = MediaWiki::API->new;
>       $mediawiki->{config}->{api_url} = "$url/api.php";
>       if ($wiki_login) {
> -             my %credential = credential_from_url($url);
> +             my %credential;
>               $credential{username} = $wiki_login;
>               $credential{password} = $wiki_passwd;
> -             credential_run("fill", \%credential);
> +             credential_run("fill", \%credential, $url);
>               my $request = {lgname => $credential{username},
>                              lgpassword => $credential{password},
>                              lgdomain => $wiki_domain};

I would find it more elegant not to special-case the URL field, and just

  my %credential = ('url' => $url);

but I'm fine with your version too.

Other than that, and for the 4 patches of the serie:

Reviewed-by: Matthieu Moy <matthieu....@imag.fr>

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to