Jeff King <p...@peff.net> writes:
> I started with a version that did that, but there are two complications:
> 1. credential_write needs to know that the 'url' field must come
> first, as it overwrites the other fields. So we end up
> special-casing it either way.
Right, I didn't think of that. But you'd have to special-case it only
within credential_run, and not for the caller.
> 2. Git hands us back the broken-down version, which we add to the
We don't add it, but already replace the whole structure. This is
somehow needed because "git credential fill" can remove fields from the
structure (the path attribute is removed with
credential.useHttpPath=false). So, this point doesn't seem problematic.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html