Hi,

Jiang Xin wrote:

> Mark additional 3 strings for translation, and reduce one indentation
> level for one gettextln clause introduced in commit de88c1c.

The above description doesn't mention:

[...]
> @@ -387,8 +386,8 @@ do
>       -i|--interactive)
>               interactive=t ;;
>       -b|--binary)
> -             echo >&2 "The $1 option has been a no-op for long time, and"
> -             echo >&2 "it will be removed. Please do not use it anymore."
> +             echo >&2 $(gettext "The -b option has been a no-op for long 
> time, and
> +it will be removed. Please do not use it anymore.")

... that this changes the message when the --binary option is passed.
Before this patch, it says

        The --binary option has been a no-op for a long time, and ...

After the patch, it says

        The -b option has been a no-op for a long time, and ...

Intentional?  That may be a good change or a bad one (I haven't
thought clearly about it), but it seems at least worth mentioning.
Cc-ing Thomas in case he has advice.

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to