On Fri, Aug 10, 2012 at 11:08 AM, Jeff King <p...@peff.net> wrote: > On Fri, Aug 10, 2012 at 11:06:08AM -0700, Dave Borowitz wrote: > >> > I asked the folks who run code.google.com and they are indeed seeing >> > something like these in their logs: >> > >> > >> Client asked for capability agent=git/1.7.12.rc2.79.g86c1702 that was >> > not advertised. >> >> FWIW, this error comes from Dulwich: >> https://github.com/jelmer/dulwich/blob/25250c1694dac343d469742aeafa139f37fc4ec6/dulwich/server.py#L196 > > Thanks for the data point. I knew you guys ran some custom code, so I > wasn't sure how widespread this is. The fact that other dulwich-based > servers would see the same issue makes me doubly sure that my fix is the > right direction.
You may also notice in that code a set of innocuous_capabilities, which IIRC is the complete set of capabilities, at the time of writing, that the C git client may send without the server advertising them. Such a set (painstakingly assembled, I assure you :) may be useful as we move further in this direction. >> So any servers running Dulwich would be affected by this...though I'm >> not aware of any large-scale Dulwich installations other than Google >> Code. > > I'd rather not break small-scale installations, either. :) > > -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html