Florian Achleitner <florian.achleitner.2.6...@gmail.com> writes:

> On Friday 17 August 2012 21:16:59 Junio C Hamano wrote:
>> Comments from mentors and people interested in remote helpers?
>> I did minimum line wrapping, typofix and small compilation fixes
>> and queued these on 'pu'; I think I saw one commit whose message
>> I didn't quite get what it was trying to say, and another that was
>> missing S-o-b (I left them untouched).
> Should I provide a better version? I found the commit that I forgot to sign-
> off, but I'm not sure which message you mean.

There was a one with "E.g:" followed by an incomplete sentence that
did not parse for me.  Can you fetch 'pu', run format-patch on your
topic and compare the output with what you sent to the list?

>> The result merged to 'pu' seems to fail 9020, by the way.
> That's because contrib/svn-fe isn't built automatically if you call make in 
> the toplevel dir. 
> It dies with "fatal: Unable to find remote helper for 'svn'", because the 
> helper is not built. We currently need to run make in contrib/svn-fe 
> seperately.
> That's a bit awkward.

That indicates that one necessary patch to add logic to Makefile to
go and build that subdirectory, at least before running the test,
but possibly as part of the "all" target, is missing, isn't it?

Or you can add, at the beginning of your tests files that require
the contrib bit, to have something like

        if test -e "$GIT_BUILD_DIR/remote-svn"
                test_set_prereq REMOTE_SVN

and protect your tests with the prerequisite, e.g.

        test_expect_success REMOTE_SVN 'test svn:// URL' '

without changing the top-level Makefile.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to