On Tue, Aug 21, 2012 at 3:06 AM, Michael Haggerty <mhag...@alum.mit.edu> wrote:
> On 08/19/2012 12:21 PM, Marco Schulze wrote:
>> It is a bit of a pain to work with libsvn, but I think it is worth using
>> it, not only due to protocol support, but also due to ready-to-use
>> support for SVN deltas and dumps.  Pipelining could be implemented by
>> maintaining a set of connections (svn_ra_session_t structures) and
>> manually distributing work between them.
> Using libsvn would also have the benefit of letting the Subversion
> project worry about forwards and backwards compatibility if the protocol
> ever changes.  (They tend to be quite diligent about that.)

So my goal with the svn support is not so much to support pushing to
svn, but to support it natively. What I mean by that is that it will
use the git configuration for http, auth, ssl, etc. For the svn
protocol there is little to none of this, but frankly the svn protocol
is a one to one mapping to the svn editor interface and very simple to
boot. So working off the interface vs working off of the protocol
there isn't much different in the complexity or amount of code. For
HTTP though there is a huge benefit to working outside libsvn. Namely
reusing the http support in git means all of the credential, http, ssl
config works. Also these days again there isn't much difference
between the http interface and the svn editor interface.

As for diffs and dumps ... Well svn diff parsing and generation is
relatively trivial (200-300 lines currently). I have no real plan
currently to deal with dumps.

I've since added support for HTTP. What I'll do is add a third
interface in the same manner that uses libsvn. If it turns out simple
enough then that would be the way to go for dumps and svn, but I'm
very skeptical about using that for HTTP+svn (can't be fully sure
without trying I suppose).

TLDR: You've convinced me to at least give it a try.

-- James
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to