"Joachim Schmitz" <j...@schmitz-digital.de> writes:
> Reminds me of a related issue: in compat/fnmatch/fnmatch.c there is this:
> #if HAVE_STRING_H || defined _LIBC
> # include <string.h>
> # include <strings.h>
> There's no place where HAVE_STRING_H get set
> This looks wrong to me,...
This is because it is a borrowed file from glibc, and we try to
minimize changes to such a file.
If you need HAVE_STRING_H to force inclusion of <string.h> on your
platform, doing this:
> COMPAT_CFLAGS += -DHAVE_STRING_H=1 # needed in compat/fnmatch/fnmatch.c
is perfectly the right thing to do.
> Do platforms exist without string.h?
> Maybe fnmatch.c should look like this instead?
We try to minimize changes to such a file we borrow from upstream;
especially we do not do so lightly when we have to ask "do platforms
exist?" Of course, they do---otherwise glibc folks wouldn't have
written such a conditional.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html