Erik Faye-Lund <> writes:

> On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones
> <> wrote:
>> The getline() function is a GNU extension (you need to define
>> _GNU_SOURCE before including stdio.h) and is, therefore, not
>> portable. In particular, getline() is not available on MinGW.
> Actually, getline is a POSIX-2008 feature, so it's not (simply) a GNU 
> extension:

True, thanks for pointing it out.  Justify the change with something
like this instead, perhaps?

        The getline() function, even though is in POSIX.1-2008, is
        not available on some platforms.  Use strbuf_getline() for

By the way, the remainder of the proposed log message talks about
the difference between getline() that keeps the terminating LF vs
strbuf_getline() that drops it.  Would strbuf_getwholeline() be a
better alternative?

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to