Junio C Hamano wrote:
> Erik Faye-Lund <kusmab...@gmail.com> writes:
>> On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones
>> <ram...@ramsay1.demon.co.uk> wrote:
>>> The getline() function is a GNU extension (you need to define
>>> _GNU_SOURCE before including stdio.h) and is, therefore, not
>>> portable. In particular, getline() is not available on MinGW.
>> Actually, getline is a POSIX-2008 feature, so it's not (simply) a GNU 
>> extension:
>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/getline.html
> True, thanks for pointing it out.  Justify the change with something
> like this instead, perhaps?
>       The getline() function, even though is in POSIX.1-2008, is
>       not available on some platforms.  Use strbuf_getline() for
>       portability.
> By the way, the remainder of the proposed log message talks about
> the difference between getline() that keeps the terminating LF vs
> strbuf_getline() that drops it.  Would strbuf_getwholeline() be a
> better alternative?

I don't think it matters; I was just making sure Florian was aware
of the difference (it will not appear in the commit message anyway),
including the memory leak in the original code.

Ramsay Jones

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to