Junio C Hamano wrote: > Ramsay Jones <ram...@ramsay1.demon.co.uk> writes: > >> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK >> variable, either from the environment or command line of an >> 'make test' invocation. In order to allow the malloc checks to be >> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK >> to the environment using an export directive. > > We would want to encourage people to test with cheap but effective > checks when available. I do not see "malloc: using debugging hooks" > message anywhere when I run tests, but if you do, I'd rather see us > check if we can tell glibc to stop doing so first without disabling > the whole test. Your patch feels like the first step to a slipperly > slope whose destination would make us say "we get too many messages > so let's do nothing in "make test" with this configuration." when > taken to the extreme, and obviously we would not want to go there > ;-).
[sorry for the late reply, I've been away ...] Yes, but ... I really don't see that this patch would encourage anyone to skip the malloc checks, who wasn't going to anyway! I didn't notice much of an increase in the running time of the tests, so that wouldn't discourage me. This idiotic message spewage is a different issue. (the complete loss of terminal scroll-back is particularly annoying) I had intended to run the tests with malloc checks enabled before submitting patches, testing -rc* builds etc., but have them disabled for day-to-day programming. > Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK > to your environment before running "make test" suffice? Yes, so I can simply disable the malloc checks in my ~/.bashrc file. However, it would be disappointing to have my config tweeks in two places ... :( I guess I can live with it ... ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
