On Thu, Sep 1, 2016 at 1:01 AM, Christian Couder
<christian.cou...@gmail.com> wrote:
> On Thu, Sep 1, 2016 at 12:07 AM, Stefan Beller <sbel...@google.com> wrote:
>>> Printing on stdout, and calls to warning() or error() are not
>>> taken care of in this patch, as that will be done in following
>>> patches.
>>> -               if (state->apply_verbosely)
>>> +               if (state->apply_verbosity > verbosity_normal)
>>>                         error(_("while searching for:\n%.*s"),
>>>                               (int)(old - oldlines), oldlines);
>> But this is an error(..) ?
> Do you mean that it was a bug in the original code to print this error
> only in verbose mode?

Oh never mind.

I meant to point out the inconsistency between the commit message, that
said: "error() are not taken care of in this patch" and modifying a
condition for
an error call. However we need to fix them as you renamed apply_verbosely
to apply_verbosity and made it an enum. So I spoke too early.

> Anyway I don't think such a refactoring is needed.

great :)

Reply via email to