Kirill Smelkov <k...@nexedi.com> writes: > On Thu, Aug 18, 2016 at 01:52:22PM -0400, Jeff King wrote: > > > > Good to know there is no regression. It is curious that there is a > > slight _improvement_ across the board. Do we have an explanation for > > that? It seems odd that noise would be so consistent. > > Yes, I too thought it and it turned out to be t/perf/run does not copy > config.mak.autogen & friends to build/ and I'm using autoconf with > CFLAGS="-march=native -O3 ..." > > Junio, I could not resist to the following: > ... > With corrected t/perf/run the timings are more realistic - e.g. 3 > consecutive runs of `./run 56dfeb62 . ./p5310-pack-bitmaps.sh`:
Wow, that's what I call an exchange with quality during a review ;-) Thanks for the curiosity and digging it to the root cause of the anomaly. Some GNUism/bashism in the way copying is spelled in the patch bothers me, but that is easily fixable. Thanks.
