On 17/09/16 17:21, Josh Triplett wrote:
This provides a shorter and more convenient alias for
--subject-prefix='RFC PATCH'.

Includes documentation in the format-patch manpage, and a new test
covering --rfc.

Signed-off-by: Josh Triplett <j...@joshtriplett.org>

Sounds good to me. Agreed that "RFC" is essentially the only prefix other than "PATCH" that I see, at least in the kernel.

I don't have anything to say about the code, though I did note that there's a error message stating that "--subject-prefix and -k are mutually exclusive." - I haven't tested the patch, but I imagine this message will trigger with --rfc as well and could be slightly confusing.

- Add documentation to the format-patch manpage
- Call subject_prefix_callback rather than reimplementing it
- Update test to move expectations inside

 Documentation/git-format-patch.txt |  8 +++++++-
 builtin/log.c                      |  8 ++++++++
 t/t4014-format-patch.sh            |  9 +++++++++
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-format-patch.txt 
index 9624c84..b9590a5 100644
--- a/Documentation/git-format-patch.txt
+++ b/Documentation/git-format-patch.txt
@@ -19,7 +19,8 @@ SYNOPSIS
                   [--start-number <n>] [--numbered-files]
                   [--in-reply-to=Message-Id] [--suffix=.<sfx>]
-                  [--subject-prefix=Subject-Prefix] [(--reroll-count|-v) <n>]
+                  [--rfc] [--subject-prefix=Subject-Prefix]
+                  [(--reroll-count|-v) <n>]
                   [--to=<email>] [--cc=<email>]
                   [--[no-]cover-letter] [--quiet] [--notes[=<ref>]]
                   [<common diff options>]
@@ -172,6 +173,11 @@ will want to ensure that threading is disabled for `git 
        allows for useful naming of a patch series, and can be
        combined with the `--numbered` option.

+       Alias for `--subject-prefix="RFC PATCH"`. Use this when
+       sending an experimental patch for discussion rather than
+       application.

Perhaps mention the phrase "Request For Comment" for the benefit of those who aren't familiar (which admittedly, among users of git-format-patch, are probably rather few, but still).

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com  IBM Australia Limited

Reply via email to