Junio C Hamano <gits...@pobox.com> writes:

> Kevin Daudt <m...@ikke.info> writes:
>
>> +static void unquote_quoted_string(struct strbuf *line)
>> +{
>> +    const char *in = strbuf_detach(line, NULL);
>> +    int c, take_next_literally = 0;
>> +    int found_error = 0;
> ...
>> +    }
>> +}
>
> The additional comment makes it very clear what is going on.
>
> Is it an event unusual enough that is worth warning() about if we
> have either take_next_literally or escape_context set to non-NUL
> upon leaving the loop, I wonder?
>
> Will queue.  Thanks.

It turns out that found_error is not used anywhere and tripped the
-Werror=unused-variable check.  I've removed that line while
queuing.

Thanks.

Reply via email to