santi...@nyu.edu writes: > From: Santiago Torres <santi...@nyu.edu> > > The format specifier will be likely used in other functions throughout > git tag. One likely candidate to require format strings in the future is > the gpg_verify_tag function. However, changing the signature of > functions such as for_each_ref or verify_tag would be quite burdensome.
I do not understand the above excuse. for-each-ref takes a callback data pointer exactly because it wants you to be able to extend what data the callback function gets without changing its signature. builtin/tag.c::verify_tag() is a helper static to the file--why should it be "burdensome" to change it to fit your needs? Adding technical debt by going backwards is never a good idea especially done to add a new feature that is not desperately needed.