Kevin Daudt <m...@ikke.info> writes:
> Many tests need to store data in a file, and repeat the same pattern to
> refer to that path:
> Create a variable that contains this path, and use that instead.
> Signed-off-by: Kevin Daudt <m...@ikke.info>
> Signed-off-by: Junio C Hamano <gits...@pobox.com>
> Changes since v2:
> - changed $DATA to $data to indicate it's a script-local variable
If you are rerolling anyway, I would have liked to see the "why is
only the variable part quoted?" issue addressed which was raised
during the previous round of the review. I may have said it is OK
to leave it as a low-hanging fruit for others but that only meant
that it alone is not a strong enough reason to reroll this patch.
Other than that, looks good to me, though ;-)