A Sex, 30-09-2016 às 19:26 +0200, Jakub Narębski escreveu: > W dniu 31.08.2016 o 14:31, Vasco Almeida pisze: > > Mark messages in here document without interpolation for > translation. > > > > Marking for translation by removing here documents this way, rather > than > > take advantage of "print __ << EOF" way, makes other instances of > help > > messages in clean.c match the first two in this file. Otherwise, > > reusing here document would add a trailer newline to the message, > making > > them not match 100%, hence creating two entries in pot template for > > translation rather than a single entry. > > This is good catch, but I think it goes backwards with the solution. > > If the text to be translated is multi-line, and it must end with > newline, > why is this final newline not included in the msgid? This would > involve > turning printf_ln into printf, and adding trailing newline in final > entry for builtin/clean.c:295, etc. - I think it is better solution > than > uglyifing git-add--interactive.perl > > Though it is not much of uglifying thanks to Perl support for > embedded > newlines in double-quoted strings.
I will do this for the next re-roll. Thanks
