Re: [PATCH] push: change submodule default to check

[Junio C Hamano]

Stefan Beller <sbel...@google.com> writes:

> +static void preset_submodule_default(void)
> +{
> +     if (file_exists(".gitmodules"))

Don't we need to see if we are in a bare repository?

> +             recurse_submodules = RECURSE_SUBMODULES_CHECK;
> +     else
> +             recurse_submodules = RECURSE_SUBMODULES_DEFAULT;

Hmph, why "_DEFAULT" not "_OFF"?

> +}
> +
>  static void add_refspec(const char *ref)
>  {
>       refspec_nr++;
> @@ -552,6 +560,7 @@ int cmd_push(int argc, const char **argv, const char 
> *prefix)
>       };
>  
>       packet_trace_identity("push");
> +     preset_submodule_default();
>       git_config(git_push_config, &flags);
>       argc = parse_options(argc, argv, prefix, options, push_usage, 0);
>       set_push_cert_flags(&flags, push_cert);