Junio C Hamano <[email protected]> writes: > Stefan Beller <[email protected]> writes: > >> +static void preset_submodule_default(void) >> +{ >> + if (file_exists(".gitmodules")) > > Don't we need to see if we are in a bare repository? > >> + recurse_submodules = RECURSE_SUBMODULES_CHECK; >> + else >> + recurse_submodules = RECURSE_SUBMODULES_DEFAULT; > > Hmph, why "_DEFAULT" not "_OFF"?
... because you wanted to keep the same behaviour, i.e. keep recurse_submodules set to _DEFAULT just like the compiled-in initialization does. Perhaps we can lose "else" clause altogether?
