Jeff King <p...@peff.net> writes: > On Thu, Dec 01, 2016 at 12:25:59PM -0800, Brandon Williams wrote: > >> Add the from_user parameter to the 'is_transport_allowed' function. >> This allows callers to query if a transport protocol is allowed, given >> that the caller knows that the protocol is coming from the user (1) or >> not from the user (0), such as redirects in libcurl. If unknown, a -1 >> should be provided which falls back to reading `GIT_PROTOCOL_FROM_USER` >> to determine if the protocol came from the user. > > Patches 3 and 4 look good to me (1 and 2 are unchanged, right? They are > already in 'next' anyway, though I guess we are due for a post-release > reset of 'next').
Yes. I am planning to take a day off tomorrow, and probably will rewind 'next' sometime this the weekend. I agree with the comments you made in the remainder of the message I am responding to, so I'll snip it. >> diff --git a/http.c b/http.c >> index fee128b..e74c0f0 100644 >> --- a/http.c >> +++ b/http.c >> ... > > This is better, but I think we still need to deal with http-alternates > on top. > ...
