On 03/13, Devin Lehmacher wrote:
> > +static int is_socket(char *path) {
> > + struct stat sb;
> > + int ret = lstat(path, &sb);
> > + return ret && S_IFSOCK(sb.st_mode);
> > +}
>
> This patch won’t even compile. S_IFSOCK(sb.st_mode) should have been S_IFSOCK
> & sb.st_mode.
>
> (I guess I should have compiled first)
>
> After making that change this patch compiles (currently running tests).
Best practice for submitting patches would be to ensure that each patch
compiles without errors (with the DEVELOPER=1 flag set) and that the
entire test suite passes with no errors; this is to maintain
bisect-ability. Only after you've done this should you send your
patches to the mailing list.
--
Brandon Williams
