Devin Lehmacher <lehma...@gmail.com> writes: > Signed-off-by: Devin Lehmacher <lehma...@gmail.com> > Reviewed-by: Junio C Hamano, Jeff King
The last line is premature; neither of us reviewed this exact version and haven't checked if all the issues we mentioned in the previous review have been addressed. > +static char *get_socket_path(void) { Compare ths line with how cmd_main() below is declared. Notice any difference? We begin our functions like this: static char *get_socket_path(void) {