On Sun, Jul 09, 2017 at 09:59:33AM -0700, Junio C Hamano wrote: > >> After step 6/7, we no longer "allow cycles in reflog ancestry", as > >> there will be no reflog ancestry to speak of ;-), so it would be > >> nice to remove the comment above in that step. But alternatively, > >> we can rephrase the comment here, to say something like "the same > >> commit can be shown multiple times while showing entries from the > >> reflog" instead. > > > > I actually think the comment is a bit obtuse in the first place. The > > real issue is that we show commits multiple times. That's caused by > > cycles, yes, but also by us clearing the SEEN flag. ;) > > > > Maybe this on top? > > Yup, that is a much better version of what I had in mind that can go > either before this step as a preparatory cleanup, squashed into this > as "while at it", or after the series as a finishing touches. The > last one will let the codebase lie for a short while, though, so I am > likely to squash it in or wiggle it under.
Where you put it on jk/reflog-walk in your tree is fine, though note the commit message is slightly inaccurate there (it says "commit buffer and parents" but at that point it is really just "commit buffer"). -Peff
