Am 13.08.2017 um 06:32 schrieb Jeff King:
> On Sat, Aug 12, 2017 at 01:57:06PM +0200, René Scharfe wrote:
>> But we probably want to check for other errors.  They look unlikely
>> enough that we may get away with something like this:
>>      -       if (errno == ENOMEM)
>>      -               die("Out of memory, getdelim failed");
>>      +       if (errno || ferror(fp))
>>      +               die_errno(_("getdelim failed"));
>> NB: The other errors are EINVAL (input pointers are NULL or the
>> stream is invalid) and EOVERFLOW (read more than fits into ssize_t)
>> according to POSIX and the Linux manpage.
> Can't we also get any of the errors that fgetc() would return. I.e., any
> normal read errors? We should return EOF on those, not die (and the
> caller can check ferror()).

Yes, we can get those as well, and leaving error checking to the caller
is a flexible way to handle them.  

Many of the existing callers don't seem to be bother, though.


Reply via email to