On 27.11.2012, at 21:39, Junio C Hamano wrote: > Max Horn <m...@quendi.de> writes: > >> Subject: Re: [PATCH 3/6] Fix grammar > > Please run "git shortlog -200 --no-merges" from the tip of your > topic branch before sending a series out, and see if you can > immediately identify what area each of your patches affects.
First off: I apologize for the inconvenience my stumbling causes :-(, and I'll try to learn and do better next time I send this or another series. In this particular case, I am not 100% sure if I understood you correctly, i.e. what exactly you are trying to tell me. Is it (in a nutshell) that the subject lines of my commits suck, as they don't identify which area of code they touch? At least that's the thing I notice when looking at that shortlog... Bad, of course... If this is indeed it, would a commit message like git-remote-helper.txt: minor grammar fix be OK? If this is indeed it, I'll be happy to reroll and resubmit the series accordingly. If I am mistaken and something else / more is wrong, please be so kind and let me know, too. Sorry once more and thank you very much for your feedback, Max > >> Signed-off-by: Max Horn <m...@quendi.de> >> --- >> Documentation/git-remote-helpers.txt | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/git-remote-helpers.txt >> b/Documentation/git-remote-helpers.txt >> index db63541..7eb43d7 100644 >> --- a/Documentation/git-remote-helpers.txt >> +++ b/Documentation/git-remote-helpers.txt >> @@ -235,9 +235,9 @@ Commands are given by the caller on the helper's >> standard input, one per line. >> 'capabilities':: >> Lists the capabilities of the helper, one per line, ending >> with a blank line. Each capability may be preceded with '*', >> - which marks them mandatory for git version using the remote >> - helper to understand (unknown mandatory capability is fatal >> - error). >> + which marks them mandatory for git versions using the remote >> + helper to understand. Any unknown mandatory capability is a >> + fatal error. >> >> 'list':: >> Lists the refs, one per line, in the format "<value> <name> > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html