Hi kusma, On Tue, 13 Nov 2012, Erik Faye-Lund wrote:
> The getpass-implementation we use on Windows isn't at all ideal; > it works in raw-mode (as opposed to cooked mode), and as a result > does not deal correcly with deletion, arrow-keys etc. > > Instead, use cooked mode to read a line at the time, allowing the > C run-time to process the input properly. Awesome! The patch itself has a couple Windows-specific things in compat/terminal.c that I would have loved to see in compat/mingw.c instead, but it looks as if we have no choice: restore_term() and disable_echo() need to be substantially different enough from the implementation in compat/mingw.c. (Read: I am fine with this patch.) Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
