On Thu, Jan 11, 2018 at 07:57:51PM +0100, René Scharfe wrote: > > If we already have the list of tips, could we just feed it ourselves to > > bisect_rev_setup (I think that would require us remembering which were > > "good" and "bad", but that doesn't seem like a big deal). > > That's done already under the covers. De-globalizing these variables > would make this visible. > > Another way would be to store the bad and good revs in a format that > allows them to be used everywhere, thus avoiding confusing > duplication/conversions. Commit pointers and arrays thereof should > work everywhere we currently use object_ids and oid_arrays for bad > and good revs, right?
I think bisect_rev_setup() has to munge that into "^" and non-"^" arguments. Though arguably we could shove stuff into the pending commit list directly. I dunno. It may not be worth spending more time on it. -Peff
