On Sun, Feb 4, 2018 at 1:55 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > On Sun, Feb 04 2018, Lucas Werkmeister jotted: >> [--inetd | >> [--listen=<host_or_ipaddr>] [--port=<n>] >> [--user=<user> [--group=<group>]]] >> + [--log-destination=(stderr|syslog|none)] > > I micronit, but maybe worthwhile to have a preceeding commit to fix up > that indentation of --listen and --user.
The '--listen' and '--user' lines are in the "alternate" ('|') branch of '--inetd' so, as Lucas points out, this indentation appears intentional, thus seems okay as-is. >> +--log-destination=<destination>:: >> + Send log messages to the specified destination. >> + Note that this option does not imply --verbose, > > Should `` quote --verbose, although I see similar to the WS change I > noted above there's plenty of existing stuff in that doc doing it wrong. As you mention, there are plenty of existing offenders already in this file, so probably not worth a re-roll (perhaps Junio can fix this new instance locally), but certainly good fodder for a follow-up patch. >> + } else >> + die("unknown log destination '%s'", v); > > Should be die(_("unknown..., i.e. use the _() macro. No message in this source file use _(...) yet so probably not worth a re-roll, but definitely something for a follow-up patch (by someone).