On Wed, Feb 14, 2018 at 10:16 AM, Jeff King <p...@peff.net> wrote:
> Hmm. That is not too bad, but somehow it feels funny to me to be
> polluting each test script with these annotations. And to be driving it
> from inside the test scripts.
> It seems like:
>   make SANITIZE=leak test GIT_SKIP_TESTS="$(cat known-leaky)"
> would be sufficient.

And all new test files are considered leak-free by default? I like that!

> And updating the list would just be:
>   # assume we're using prove, which will keep running after failure,
>   # and will record the results for us to parse (using "--state=").
>   # Otherwise use "make -k" and grep in t/test-results.
>   make SANITIZE=leak test
>   (cd t && prove --dry --state=failed) |
>   perl -lne '/^(t[0-9]{4})-.*.sh$/ and print $1' |
>   sort >known-leaky
> That would update both now-passing and now-failing tests. Presumably
> we'd keep it checked in, so "git diff" would show you the changes.
> -Peff


Reply via email to