On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote: > Add tests for new formatting atoms: rest, deltabase, objectsize:disk. > rest means nothing and we expand it into empty string. > We need this atom for cat-file command. > Have plans to support deltabase and objectsize:disk further > (as it is done in cat-file), now also expand it to empty string.
I'm glad that you're adding tests, but I'm not sure it's a good idea to add tests checking for the thing we know to be wrong. If anything, you could be adding test_expect_failure looking for the _right_ thing, and accept that it does not yet work. -Peff