On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote: > Move logic related to skip_object_info into ref-filter, > so that cat-file does not use that field at all.
I think this is going the wrong way. ref-filter should always do as little work as possible to fulfill the request. So it should skip the object_info call whenever it can. And then any callers who want to make sure that the object exists can do so (as long as the formatting code tells them whether it looked up the object or not). And then ref-filter doesn't have to know about this skip_object_info flag at all. -Peff